Version 2022.0 is a one off purchase, If you bought direct before, it should be a half price upgrade.
Moneydance+ is a separate bit, that MD had to move to with OFX support dwindling with banks. That costs $2/month, but it is OPTIONAL. If you don't need extensive connections to bank automatic downloads, you don't have to use it, nor pay for it.
The one off purchase (direct) also entitles you to another year upgrade (say 2023) for free before you'd pay again (and you don't have to upgrade at all if you are satisfied with the version you are using).
the one off upgrade will allow you to use icloud for syncing vs. dropbox. BUT, the ios iphone/ipad bits aren't in place yet, though syncing with icloud between mac computers works. the rest is coming (hopefully) within a month.